Summary

Delivers and evaluates the standalone review-fix-loop local_commit workflow: the actual end-to-end loop design/review-fix-loop.md's "Workflow" section describes (steps 1 "Resolve" through 9 "Return"), composing the three already-merged children of epic #95 without reimplementing any of their internals.

• skills/review-fix-loop/scripts/local_commit.py — run_local_commit(...) composes:
  • validate.py (Define review-fix-loop invocation, checkpoint, and terminal-result contracts #96) for invocation/checkpoint/terminal-result contract validation;
  • local_execution.py (Implement review-fix-loop local locking, isolated attempts, and recovery #97) for candidate locking, isolated attempt worktrees, checkpointing, verified fast-forward-only promotion, and interrupted-attempt recovery;
  • reviewer_orchestration.py (Implement review-fix-loop reviewer isolation and complete-review orchestration #98) for fixed lens resolution, raw-result evaluation/binding, mutation detection, and deterministic finding ordering.
• Enforces the invocation fix-cycle budget (a cycle is reserved and consumed the moment an attempt starts, regardless of outcome).
• Commits selected fixes in an isolated attempt and promotes only a converged candidate; never performs a remote write under local_commit.
• Detects the candidate-visible non-convergence stops the design names (expanding_findings, oscillation, repeated_failed_attempt, cycle_budget_exhausted) without second-guessing a finding that simply survives one fix within budget (see references/local-commit.md for why that specific case is deliberately not an automatic early stop).
• Reports declined findings and their rationale, explicit retained-commit (unpushed_commits) and operator_action evidence for every non-converged stop.
• skills/review-fix-loop/references/local-commit.md documents the composition, the three host-boundary ports (reviewer, decide, apply_fix), and every terminal state this module returns.
• skills/review-fix-loop/scripts/tests/test_local_commit.py — 21 end-to-end tests against real temporary Git repositories (no mocked Git state): immediate convergence, one and multiple fix cycles, budget exhaustion, a validation failure that is unavailable/untractable/tractable, a declined finding and a scope-expanding fix (operator input), expanding and oscillating finding sets, repeated failed attempts, interrupted-attempt recovery, an already-held candidate lock, an attempted reviewer mutation, a host without fresh-subagent support, a bound source-binding's ahead/behind reporting, and a regression test reproducing (and proving fixed) a stale-disposition defect a first review pass found.
• Updates SKILL.md to document the new entry point and records today's changelog entry.

Review history

Two full fresh-subagent review-code-change passes:

1. Initial pass (head 498983d): changes_required — one blocking correctness finding (a resumed invocation could leave a converged result carrying both a stale declined disposition and the real selected/fixed one for the same finding_id, reachable through this module's own public resume_checkpoint parameter) and one strong_recommendation finding (a local_commit invocation carrying a schema-legal source_binding still reported source: unavailable instead of the terminal-result contract's own named "local ahead/behind state ... when a source is bound").
2. Fix cycle (head cc9d86a): both findings fixed — _State.record_finding_disposition now always replaces any prior entry for a finding_id before appending a new one; _checkpoint_source_status/_terminal_source_status now compute real ahead/behind counts via git rev-list --count whenever a source binding is present. Two regression tests added reproducing each defect directly.
3. Re-review (head cc9d86a): clean. Both fixes independently verified; solution-simplicity and code-simplicity also run fresh. One non-gating defer finding remains (the two source-status builders share near-duplicate ahead/behind computation) — preserved per the review-and-merge-gates instruction to keep deferred findings without expanding the PR; noted for a future pass.

Acceptance ledger (ticket #99)

Validation

• python3 -m unittest discover -s skills/review-fix-loop/scripts/tests -p 'test_*.py' — 253 tests, OK
• just format — no changes needed
• just lint — All checks passed (ruff, mdformat, skills-ref validate, plugin packaging)
• just test — full repository gate, OK (implement-epic 17, implement-ticket 88, review-code-change 9, review-code-simplicity 3, review-correctness 8, review-fix-loop 253, review-solution-simplicity 5, review-suite 318)

Fixes #99

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com